Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envconfig: remove env vars for on-by-default features #6749

Merged
merged 1 commit into from
Oct 26, 2023
Merged

envconfig: remove env vars for on-by-default features #6749

merged 1 commit into from
Oct 26, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Oct 25, 2023 •
edited
Loading

Unfortunately the diffs are quite large, but it's very mechanical and should be quick to remove since it's all red code.

RELEASE NOTES: none

@dfawley dfawley added the Type: Internal Cleanup Refactors, etc label Oct 25, 2023
@dfawley dfawley added this to the 1.60 Release milestone Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #6749 (db61343) into master (6e14274) will increase coverage by 0.13%.
The diff coverage is 84.74%.

Additional details and impacted files

@arvindbr8 arvindbr8 self-assigned this Oct 26, 2023
arvindbr8
arvindbr8 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one comment

internal/testutils/xds/bootstrap/bootstrap.go Show resolved Hide resolved
xds/internal/balancer/clusterresolver/configbuilder.go Show resolved Hide resolved
@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Oct 26, 2023
@dfawley dfawley merged commit 8190d88 into grpc:master Oct 26, 2023
13 checks passed
@dfawley dfawley deleted the flags branch October 26, 2023 20:08
arvindbr8 pushed a commit to arvindbr8/grpc-go that referenced this pull request Nov 7, 2023
@dfawley @arvindbr8
envconfig: remove env vars for on-by-default features (grpc#6749)
b17cf47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@dfawley dfawley

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.60 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @arvindbr8