resolver: manual resolver crashes if grpc.Dial isn't called before some methods #6754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Oct 31, 2023
dfawley
approved these changes
Nov 6, 2023
resolver/manual/manual_test.go
Outdated
| @@ -1,3 +1,21 @@ | |||
| /* | |||
| * | |||
| * Copyright 2017 gRPC authors. | |||
|
@arvindbr8 PTAL; thanks! |
arvindbr8
requested changes
Nov 6, 2023
resolver/manual/manual_test.go
Outdated
| }, | ||
| }) | ||
|
|
||
| t.Run("update_state", func(t *testing.T) { |
There was a problem hiding this comment.
I would prefer if the sub test description said not just update_state. This subtest asserts the panic message when updateState fails. So maybe something like
Suggested change
| t.Run("update_state", func(t *testing.T) { | |
| t.Run("update_state_panics", func(t *testing.T) { |
resolver/manual/manual_test.go
Outdated
| {Addr: "anotheraddress"}, | ||
| }}) | ||
| }) | ||
| t.Run("report_error", func(t *testing.T) { |
resolver/manual/manual_test.go
Outdated
| r.ReportError(errors.New("example")) | ||
| }) | ||
|
|
||
| _, err := grpc.Dial("whatever://localhost", |
There was a problem hiding this comment.
This seems like another subTest to me. I would prefer if we did this also inside of a t.Run("happy path", func(t *testing.T)
arvindbr8
approved these changes
Nov 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add panic message when manual resolver crashes if
grpc.Dial()isn't called before setting ClientConnRELEASE NOTES: none