Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds/server: Fix nil panic in xDS Server when received LDS with no inline RDS #6755

Closed
wants to merge 2 commits into from
Closed

xds/server: Fix nil panic in xDS Server when received LDS with no inline RDS #6755

wants to merge 2 commits into from

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Oct 31, 2023 •
edited
Loading

This PR fixes a nil panic in Listener Wrapper, from a nil receiver described in issue #6683.

RELEASE NOTES:

  • xds/server: Fix nil panic in xDS Server when received LDS with no inline RDS

@zasweq zasweq changed the base branch from master to v1.59.x October 31, 2023 00:59
@zasweq zasweq requested a review from dfawley October 31, 2023 01:00
@zasweq zasweq added this to the 1.59 Release milestone Oct 31, 2023
@zasweq zasweq changed the title xds/internal/server: Fix nil panic in Listener Wrapper xds/server: Fix nil panic in xDS Server when received LDS with no inline RDS Oct 31, 2023
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #6755 (38c8515) into v1.59.x (eb100ba) will decrease coverage by 0.02%.
The diff coverage is 78.94%.

Additional details and impacted files

@zasweq zasweq mentioned this pull request Nov 1, 2023
Closed
@dfawley dfawley closed this Nov 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley Awaiting requested review from dfawley

Assignees

@dfawley dfawley

Labels
Type: Bug
Projects
None yet
Milestone
1.59 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@zasweq @dfawley