Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds/resolver: extend test to re-add listener #6768

Merged
merged 1 commit into from
Nov 6, 2023
Merged

xds/resolver: extend test to re-add listener #6768

merged 1 commit into from
Nov 6, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 6, 2023 •
edited
Loading

This is just for peace of mind since a similar situation came up in interop tests, and I wanted to make sure it was handled correctly.

RELEASE NOTES: none

@dfawley dfawley added this to the 1.60 Release milestone Nov 6, 2023
@dfawley dfawley requested a review from zasweq November 6, 2023 17:41
zasweq
zasweq approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dfawley dfawley merged commit a5a7ef2 into grpc:master Nov 6, 2023
1 check passed
@dfawley dfawley deleted the xrt branch November 6, 2023 19:28
arvindbr8 pushed a commit to arvindbr8/grpc-go that referenced this pull request Nov 7, 2023
@dfawley @arvindbr8
xds/resolver: extend test to re-add listener (grpc#6768)
e3ba603
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zasweq zasweq zasweq approved these changes

Assignees

@zasweq zasweq

Labels
Type: Testing
Projects
None yet
Milestone
1.60 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @zasweq