buffer & grpcsync: various cleanups and improvements #6785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6785 +/- ##
==========================================
+ Coverage 83.24% 83.33% +0.08%
==========================================
Files 285 285
Lines 30950 30937 -13
==========================================
+ Hits 25765 25782 +17
+ Misses 4099 4074 -25
+ Partials 1086 1081 -5
|
arvindbr8
approved these changes
Nov 15, 2023
easwars
reviewed
Nov 28, 2023
| if len(b.backlog) > 0 { | ||
| select { | ||
| case b.c <- b.backlog[0]: | ||
| b.backlog[0] = nil | ||
| b.backlog = b.backlog[1:] | ||
| default: | ||
| } | ||
| } else if b.closing && !b.closed { |
There was a problem hiding this comment.
For correctness sake and to ensure that an extra call to Load() does not close a closed channel, we should set to b.closed to true here.
Comment on lines
41
to
+42
| closed bool | ||
| closing bool |
There was a problem hiding this comment.
I think it would be better to move these fields to be under the mu since they are clearly accessed always only with the mutex.
dfawley
added a commit
to dfawley/grpc-go
that referenced
this pull request
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: none