Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: further streamlining of Dial #6802

Merged
merged 1 commit into from
Nov 15, 2023
Merged

client: further streamlining of Dial #6802

merged 1 commit into from
Nov 15, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 15, 2023

  • Add newClient method that starts a client in idle mode.
  • Use newClient in DialContext.
  • Use default dial options as appropriate.
  • Stop cloning credentials unnecessarily. We never mutate them ourselves and a single copy is insufficient if some other LB policy ever mutates them.

RELEASE NOTES: n/a

@dfawley
client: further streamlining of Dial
5f9a247 
* Add newClient method that starts a client in idle mode.
* Use newClient in DialContext.
* Use default dial options as appropriate.
* Stop cloning credentials unnecessarily.  We never mutate them ourselves and a
  single copy is insufficient if some other LB policy ever mutates them.
@dfawley dfawley added the Type: Internal Cleanup Refactors, etc label Nov 15, 2023
@dfawley dfawley added this to the 1.61 Release milestone Nov 15, 2023
@dfawley dfawley requested a review from arvindbr8 November 15, 2023 22:16
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #6802 (5f9a247) into master (232054a) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6802      +/-   ##
==========================================
+ Coverage   83.42%   83.60%   +0.18%     
==========================================
  Files         285      285              
  Lines       30893    30883      -10     
==========================================
+ Hits        25773    25821      +48     
+ Misses       4048     4004      -44     
+ Partials     1072     1058      -14
Files Coverage Δ
balancer_wrapper.go 80.65% <100.00%> (-0.32%) ⬇️
clientconn.go 93.10% <100.00%> (+0.19%) ⬆️
dialoptions.go 88.84% <100.00%> (+0.09%) ⬆️

... and 22 files with indirect coverage changes

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Nov 15, 2023
@dfawley dfawley merged commit 914ca65 into grpc:master Nov 15, 2023
14 checks passed
dfawley added a commit to dfawley/grpc-go that referenced this pull request Dec 7, 2023
@dfawley
client: further streamlining of Dial (grpc#6802)
7e03252
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@dfawley dfawley

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.61 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @arvindbr8