Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vet: remove ignore of CloseNotifier #6911

Merged
merged 3 commits into from
Jan 9, 2024
Merged

vet: remove ignore of CloseNotifier #6911

merged 3 commits into from
Jan 9, 2024

Conversation

arvindbr8
Copy link
Member

@arvindbr8 arvindbr8 commented Jan 8, 2024 •
edited
Loading

Changes:

RELEASE NOTES: none

@arvindbr8 arvindbr8 added the Type: Internal Cleanup Refactors, etc label Jan 8, 2024
@arvindbr8 arvindbr8 added this to the 1.61 Release milestone Jan 8, 2024
@arvindbr8 arvindbr8 requested a review from dfawley January 8, 2024 23:05
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

Merging #6911 (3a38ee7) into master (5a36bb7) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6911      +/-   ##
==========================================
- Coverage   83.70%   83.68%   -0.02%     
==========================================
  Files         287      287              
  Lines       30829    30829              
==========================================
- Hits        25804    25799       -5     
- Misses       3967     3973       +6     
+ Partials     1058     1057       -1

see 17 files with indirect coverage changes

@dfawley dfawley assigned arvindbr8 and unassigned dfawley Jan 9, 2024
@arvindbr8 arvindbr8 merged commit 7e9d319 into grpc:master Jan 9, 2024
13 of 14 checks passed
@arvindbr8 arvindbr8 deleted the remove-ignore-closenotifier branch January 9, 2024 00:38
@arvindbr8 arvindbr8 linked an issue Jan 9, 2024 that may be closed by this pull request
Remove use of deprecated functions #6782
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@arvindbr8 arvindbr8

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.61 Release
Development

Successfully merging this pull request may close these issues.

Remove use of deprecated functions
2 participants
@arvindbr8 @dfawley