-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: block GracefulStop on method handlers and make blocking optional for Stop #6922
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6922 +/- ##
==========================================
- Coverage 83.72% 83.60% -0.12%
==========================================
Files 287 287
Lines 30835 30839 +4
==========================================
- Hits 25816 25783 -33
- Misses 3964 3989 +25
- Partials 1055 1067 +12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested this out as well with my repro from issue #6921 and looks like GracefulStop works as expected and Stop works as expected when the new WaitForHandlers(true)
option is passed to the server (but does not wait for handlers if that option is not passed).
@sunjayBhatia great, thank you for confirming! |
Fixes #6921
This reverts a behavior change in 1.60 for
GracefulStop
.Stop
never blocked for the method handlers, so this would introduce a behavior change forStop
if we did it by default; instead we add aServerOption
to control the behavior.RELEASE NOTES:
GracefulStop
to block until all method handlers return (v1.60 regression); addWaitForHandlers
ServerOption
(experimental) to causeStop
to also block until method handlers return (new feature).