-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds/googlec2p: use xdstp names for LDS #6949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3c8627c.
arvindbr8
changed the title
[google-c2p resolver] use xdstp names for lds
xds/googlec2p: use xdstp names for LDS
Jan 30, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6949 +/- ##
==========================================
- Coverage 83.71% 83.69% -0.02%
==========================================
Files 287 287
Lines 30926 30929 +3
==========================================
- Hits 25889 25887 -2
- Misses 3972 3976 +4
- Partials 1065 1066 +1
|
arvindbr8
added
the
Type: Behavior Change
Behavior changes not categorized as bugs
label
Jan 30, 2024
arvindbr8
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
apolcyn
added a commit
to apolcyn/grpc-go
that referenced
this pull request
Feb 5, 2024
This reverts commit 3aafa84.
arvindbr8
pushed a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Integration tests passing.
RELEASE NOTES: