Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/internal/xdsclient: Add comments for exported types #6972

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Feb 8, 2024

Fixes #6942.

RELEASE NOTES: N/A

@zasweq zasweq requested a review from arvindbr8 February 8, 2024 19:49
@zasweq zasweq added the Type: Documentation Documentation or examples label Feb 8, 2024
@zasweq zasweq added this to the 1.62 Release milestone Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Merging #6972 (96f1f8b) into master (d41b01d) will decrease coverage by 1.37%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6972      +/-   ##
==========================================
- Coverage   83.71%   82.35%   -1.37%     
==========================================
  Files         288      296       +8     
  Lines       30927    31432     +505     
==========================================
- Hits        25890    25885       -5     
- Misses       3976     4483     +507     
- Partials     1061     1064       +3     
Files Coverage Δ
xds/internal/xdsclient/xdsresource/filter_chain.go 92.74% <ø> (ø)

... and 26 files with indirect coverage changes

@arvindbr8 arvindbr8 assigned zasweq and unassigned arvindbr8 Feb 8, 2024
@ginayeh ginayeh modified the milestones: 1.62 Release, 1.63 Release Feb 8, 2024
@zasweq zasweq merged commit f135e98 into grpc:master Feb 9, 2024
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported var/type/method missing comment
3 participants