replace github.com/cncf/udpa/go by github.com/cncf/xds/go #7001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7001 +/- ##
==========================================
- Coverage 82.43% 82.30% -0.14%
==========================================
Files 296 296
Lines 31473 31473
==========================================
- Hits 25946 25905 -41
- Misses 4468 4497 +29
- Partials 1059 1071 +12
|
|
IINM, |
|
It looks like the two are equivalent now? https://github.com/cncf/udpa/blob/c52dc94e7fbe/go/udpa/type/v1/typed_struct.go#L8 |
dfawley
reviewed
Feb 27, 2024
dfawley
added
Status: Requires Reporter Clarification
Type: Internal Cleanup
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
dfawley
approved these changes
Feb 27, 2024
arvindbr8
approved these changes
Feb 27, 2024
|
@mmorel-35 -- thanks for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
github.com/cncf/udpa/gobygithub.com/cncf/xds/goRELEASE NOTES: none
Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com