xds: Process telemetry labels from CDS in xDS Balancers #7116
Conversation
zasweq
force-pushed
the
xds-telemetry-labels
branch
from
f0b77b1 to
6f853db
Compare
internal/stats/labels.go
Outdated
|
|
||
| type labelsKey struct{} | ||
|
|
||
| // GetLabels returns the Labels stored in theo context, or nil if there is one |
There was a problem hiding this comment.
theo* and end sentence with punctuation pls.
internal/stats/labels.go
Outdated
| return labels | ||
| } | ||
|
|
||
| // SetLabels sets the Labels |
There was a problem hiding this comment.
Added in the context.
| testgrpc "google.golang.org/grpc/interop/grpc_testing" | ||
| testpb "google.golang.org/grpc/interop/grpc_testing" |
There was a problem hiding this comment.
Argh, this slipped through. Switched.
| } | ||
|
|
||
| func newPicker(s balancer.State, config *dropConfigs, loadStore load.PerClusterReporter) *picker { | ||
| func newPicker(s balancer.State, config *dropConfigs, loadStore load.PerClusterReporter, telemetryLabels map[string]string) *picker { |
There was a problem hiding this comment.
Shall we make this a method on the balancer instead of adding more parameters?
| for key, value := range d.telemetryLabels { | ||
| labels.TelemetryLabels[key] = value | ||
| } | ||
| } // Unconditionally set, even dropped or queued RPC's can use this label. |
There was a problem hiding this comment.
Move to above if info.Ctx != nil or just inside the open brace?
There was a problem hiding this comment.
Added above the info.Ctx != nil check, the comment turned out to be: Unconditionally set labels if present, even dropped or queued RPC's can use these labels.
| // handler asserts that subsequent HandleRPC calls from the RPC lifecycle | ||
| // contain telemetry labels that it can see. | ||
| func (s) TestTelemetryLabels(t *testing.T) { | ||
| managementServer, nodeID, _, resolver, cleanup1 := e2e.SetupManagementServer(t, e2e.ManagementServerOptions{}) |
| // aren't started. All of these should have access to the desired telemetry | ||
| // labels. |
There was a problem hiding this comment.
If you mean to test all 3, you will need a continue on the cases. Or case a, b, c:
This PR plumbs the Telemetry Labels from CDS through our xDS Balancer tree through the context that eventually get passed to stats handler.
RELEASE NOTES: N/A