Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/net for CVE-2023-45288 #7119

Closed
wants to merge 1 commit into from

Conversation

benjamingeer
Copy link

Update golang.org/x/net for fix for CVE-2023-45288, fixed in golang/net@ba87210

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Update golang.org/x/net for fix for CVE-2023-45288, fixed in golang/net@ba87210
Copy link

linux-foundation-easycla bot commented Apr 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: benjamingeer / name: Benjamin Geer (94ad1a2)

@arvindbr8
Copy link
Member

Posting a comparison of the upgrade here: golang/net@v0.22.0...v0.24.0

@arvindbr8
Copy link
Member

@benjamingeer -- Thanks for the PR. But you would need to also run go mod tidy to propagate the change to go.sum. Also our repo has other submodules, so you would need to go mod tidy in each sub module.

This script would be useful:

for MOD_FILE in $(find . -name 'go.mod'); do
  MOD_DIR=$(dirname ${MOD_FILE})
  pushd ${MOD_DIR}
  go mod tidy -compat=1.19
  popd
done

@dfawley
Copy link
Member

dfawley commented Apr 11, 2024

Note that we already updated to the version with the fix to this CVE (0.23) in #7081. I'm not sure what is significant about 0.24, but we'll look into it.

@arvindbr8
Copy link
Member

arvindbr8 commented Apr 11, 2024

While diffs of the tags doesnt seem to be CVE-2023-45288 related. I think we are good with (0.23).

Thanks for the PR anyways. If you are still interested in contributing to our repo, a good place to look for are issues with the label "Status: Help Wanted"

Diffs

golang/crypto@v0.21.0...v0.22.0
golang/sys@v0.18.0...v0.19.0
golang/term@v0.18.0...v0.19.0

@arvindbr8 arvindbr8 closed this Apr 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants