Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atollena to MAINTAINERS.md #7126

Merged
merged 1 commit into from
May 1, 2024
Merged

Add atollena to MAINTAINERS.md #7126

merged 1 commit into from
May 1, 2024

Conversation

atollena
Copy link
Collaborator

@atollena atollena commented Apr 15, 2024 •
edited by dfawley
Loading

As discussed offline with @dfawley and @ginayeh.

RELEASE NOTES: n/a

@atollena
Copy link
Collaborator Author

I noticed @zasweq and @ginayeh aren't part of the list.

@atollena
Add atollena to MAINTAINERS.md
a52df85 
As discussed offline with @dfawley and @ginayeh.
@atollena atollena force-pushed the add-atollena-to-maintainers branch from 24d4c41 to a52df85 Compare April 15, 2024 14:46
@dfawley
Copy link
Member

dfawley commented Apr 15, 2024

Also @arvindbr8. And we need to move Menghan and Srini to emeritus. It seems we have some bookkeeping to take care of after this PR. :)

@dfawley dfawley added the Type: Meta Github repo, process, etc label Apr 15, 2024
@dfawley dfawley added this to the 1.64 Release milestone Apr 15, 2024
@dfawley dfawley assigned dfawley and unassigned atollena Apr 17, 2024
@ginayeh
Copy link
Contributor

ginayeh commented Apr 30, 2024

@gnossen

@ginayeh ginayeh self-requested a review April 30, 2024 22:28
@gnossen
Copy link

gnossen commented Apr 30, 2024

Super excited to see you becoming a maintainer @atollena ! Very well deserved.

@kevinnilson
Copy link

Welcome to the team @atollena. It has been great getting all the amazing contributions from you to the gRPC project. I'm thrilled you are coming onboard as a maintainer and looking forward to future contributions. This is a great example of progressing from user to committer to maintainer. Great job and congrats.

markdroth
markdroth approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard, @atollena!

@ginayeh
Copy link
Contributor

ginayeh commented Apr 30, 2024

Welcome @atollena. Thanks for your contribution to gRPC Go, and we deeply appreciate your dedication to making it a better resource for the entire community. Your willingness to share your expertise and time is an inspiration to us all.

@ejona86
Copy link
Member

ejona86 commented May 1, 2024

Welcome, @atollena! Working with you has been great. I'm glad you're bringing your experience into the gRPC team!

dfawley
dfawley approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats! 🎉

@dfawley dfawley merged commit e4a6ce3 into grpc:master May 1, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@markdroth markdroth markdroth approved these changes

Assignees

@dfawley dfawley

Labels
Type: Meta Github repo, process, etc
Projects
None yet
Milestone
1.64 Release
Development

Successfully merging this pull request may close these issues.
7 participants
@atollena @dfawley @ginayeh @gnossen @kevinnilson @ejona86 @markdroth