-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: store server config for LRS server in xdsresource.ClusterUpdate #7191
Conversation
1abd1cd
to
75dd0cf
Compare
// authority. | ||
dm.LoadReportingServer = bootstrapConfig.XDSServer | ||
} | ||
LoadReportingServer: cluster.LRSServerConfig, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC we're still missing something because we aren't supporting LRS for aggregate clusters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in #7192, we currently don't support LRS for non-EDS clusters, and according to Mark, that is a bug. And with regards to aggregate clusters, Mark mentioned that the expected behavior is specified in A75, but Go hasn't implemented A74 and A75 yet.
So, in this PR, I didn't want to add LRS support for non-EDS clusters. I will do that as part of #7192.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review.
// authority. | ||
dm.LoadReportingServer = bootstrapConfig.XDSServer | ||
} | ||
LoadReportingServer: cluster.LRSServerConfig, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in #7192, we currently don't support LRS for non-EDS clusters, and according to Mark, that is a bug. And with regards to aggregate clusters, Mark mentioned that the expected behavior is specified in A75, but Go hasn't implemented A74 and A75 yet.
So, in this PR, I didn't want to add LRS support for non-EDS clusters. I will do that as part of #7192.
Summary of changes:
xdsresource.DecodeOptions
struct. This field will contain the configuration of the xDS server from where the resource was received.authority
struct inside thexdsclient
sets up this field when it receives a Cluster resource and passes it on to the data model layer for parsing and decoding.xdsresource.ClusterUpdate
struct, instead of an enum representing whether LRS is ON.ClusterUpdate
struct to the child policy config.#a71-xds-fallback
Fixes #6896
RELEASE NOTES: none