Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advancedtls: use realistic ciphersuite in test #7273

Merged
merged 1 commit into from
May 29, 2024

Conversation

rolandshoemaker
Copy link
Contributor

@rolandshoemaker rolandshoemaker commented May 28, 2024

Instead of 3DES, something which should basically never be used in production. Go is removing default support for 3DES is Go 1.24, requiring new modules to opt into support for this cipher.

This fixes an internal Google test failure, see b/343028077.

RELEASE NOTES: none

Instead of 3DES, something which should basically never be used in
production. Go is removing default support for 3DES is Go 1.24,
requiring new modules to opt into support for this cipher.
@dfawley dfawley requested a review from gtcooke94 May 28, 2024 16:51
@dfawley dfawley added this to the 1.65 Release milestone May 28, 2024
Copy link
Contributor

@gtcooke94 gtcooke94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtcooke94 gtcooke94 merged commit a4593c5 into grpc:master May 29, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants