stats: Various CSM Observability bug fixes #7278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
May 29, 2024
| @@ -44,12 +44,15 @@ func (h *clientStatsHandler) initializeMetrics() { | |||
| return | |||
| } | |||
|
|
|||
| meter := h.o.MetricsOptions.MeterProvider.Meter("grpc-go " + grpc.Version) | |||
| meter := h.o.MetricsOptions.MeterProvider.Meter("grpc-go ", otelmetric.WithInstrumentationVersion(grpc.Version)) | |||
There was a problem hiding this comment.
Delete this space in the string and the one below please.
Comment on lines
51
to
54
| setOfMetrics := DefaultMetrics.metrics | ||
| if h.o.MetricsOptions.Metrics != nil { | ||
| setOfMetrics = h.o.MetricsOptions.Metrics.metrics | ||
| } |
There was a problem hiding this comment.
Go style prefers:
setOfMetrics := h.o.MetricsOptions.Metrics
if setOfMetrics == nil {
setOfMetrics = DefaultMetrics.metricsThere was a problem hiding this comment.
Done. Note that this conditional is on the .Metrics field so switched to metrics.metrics in the create calls.
dfawley
approved these changes
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various bugs I found while interop testing CSM Observability.
RELEASE NOTES: N/A