Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update deps #7282
*: update deps #7282
Changes from all commits
0bd1bf8
dae5577
39acbda
ee38200
0391c6f
fb3e366
fbaf2a2
699416e
6796002
cee4ba3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar question here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do have a question about this, I don't think you use any feature of the language that isn't in 1.19, and that change then propagates to my library which, while I personally build binary with 1.22.5, I'd rather not force upgrade yet for users (and I was planning on a minor patch level bump but if my go.mod changes from 1.19 to 1.21 I'd have to make a new minor)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm
so I guess I would need to track down why they bumped it... possibly unnecessarily or just "because 1.19 is not supported anymore" which imo isn't a valid reason, this is about language features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the new normal for the Go ecosystem, particularly after the changes made to go.mod in 1.21. We won't bump this unless we have to, but it will become more and more likely that we'll need to shortly after any new Go version is released.