-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/protoc-gen-go-grpc: enable edition 2023 support #7351
Conversation
0bd853c
to
3b674d0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7351 +/- ##
==========================================
- Coverage 81.40% 81.39% -0.02%
==========================================
Files 348 348
Lines 26761 26761
==========================================
- Hits 21786 21783 -3
- Misses 3782 3786 +4
+ Partials 1193 1192 -1 |
3b674d0
to
f559bf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. This LGTM. Note that "RELEASE NOTES" is our auto-generated grpc library release notes, and we release protoc-gen-go-grpc separately, so I removed them from your comment.
Sorry, one request: could you add the "edition" tag to |
Sure np, I had to update the protoc version you're testing with too. But as expected, no meaningful differences to gencode |
Fixes #7067
None of the edition 2023 features affect grpc, and go-protobuf already supports editions
RELEASE NOTES: n/a