refactor:rename clientside dialoption field 'maxAttempts' #7391
Mergeable / Mergeable
failed
Jan 2, 2025 in 0s
2/3 Fail(s): LABEL, MILESTONE
Status: FAIL
Here are some stats of the run:
3 validations were ran.
1 PASSED
2 FAILED
Details
❌ Validator: LABEL
- ❌ label does not include "^Type:"
Input :
Settings :{"must_include":{"regex":"^Type:"}}
✔️ Validator: DESCRIPTION
- ✔️ description must include '^RELEASE NOTES:\s([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\n(*|-)\s.+)$'**
Input : RELEASE NOTES:
- Renamed the variable
maxCallAttemptstomaxRetryAttemptsto improve clarity and better represent its purpose.
Recently, I noticed a bug with the RPC client's setting of the maximum number of reconnections. I was very surprised to find that it has been solved in this PR client: implement maxAttempts for retryPolicy . However, I think the meaning of this variable 'maxCallAttempts' are not clear enough, so I submitted this PR to rename this variable.
Settings : {"must_include":{"regex":"^RELEASE NOTES:\\s*([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\\n(\\*|-)\\s*.+)$","regex_flag":"m"}}
❌ Validator: MILESTONE
- ❌ milestone does not include "Release$"
Input :
Settings :{"must_include":{"regex":"Release$"}}
Loading