test/channelz: change channelz_test to use write data #7396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindbr8
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7396 +/- ##
==========================================
- Coverage 81.42% 81.37% -0.05%
==========================================
Files 348 348
Lines 26744 26744
==========================================
- Hits 21775 21764 -11
- Misses 3779 3786 +7
- Partials 1190 1194 +4
|
dfawley
approved these changes
Jul 8, 2024
printchard
added a commit
to printchard/grpc-go
that referenced
this pull request
Jul 11, 2024
printchard
added a commit
to printchard/grpc-go
that referenced
this pull request
Jul 30, 2024
printchard
added a commit
to printchard/grpc-go
that referenced
this pull request
Jul 30, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the call to
WriteRawFramein order to remove that method from the new Framer API.This particular test was calling
WriteRawFrameto write a Data Frame, which could be replaced byWriteDatamethod provided by the x/net/http2 framer.RELEASE NOTES: none