Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/vet: remove trailing spaces #7426

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

purnesh42H
Copy link
Contributor

RELEASE NOTES: None

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.57%. Comparing base (64adc81) to head (e2cbd41).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7426      +/-   ##
==========================================
+ Coverage   81.50%   81.57%   +0.06%     
==========================================
  Files         350      350              
  Lines       26877    26877              
==========================================
+ Hits        21906    21924      +18     
+ Misses       3776     3767       -9     
+ Partials     1195     1186       -9     

see 18 files with indirect coverage changes

@arjan-bal arjan-bal added this to the 1.66 Release milestone Jul 18, 2024
@arjan-bal arjan-bal added the Type: Internal Cleanup Refactors, etc label Jul 18, 2024
@@ -90,7 +90,7 @@ for MOD_FILE in $(find . -name 'go.mod'); do
go mod tidy -compat=1.21
git status --porcelain 2>&1 | fail_on_output || \
(git status; git --no-pager diff; exit 1)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already fixed this in #7420, when it complained on my import. I didn't see the failure on scripts/vet-proto.sh during my import.

@purnesh42H purnesh42H merged commit 47be8a6 into grpc:master Jul 25, 2024
13 checks passed
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 30, 2024
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants