Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating route_guide.proto and generated the pb.go files #7441

Closed
wants to merge 12 commits into from

Conversation

janardhanvissa
Copy link
Contributor

No description provided.

Copy link

linux-foundation-easycla bot commented Jul 26, 2024

CLA Missing ID CLA Not Signed

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (84a4ef1) to head (64948ca).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7441      +/-   ##
==========================================
+ Coverage   81.39%   81.52%   +0.13%     
==========================================
  Files         354      354              
  Lines       27053    27053              
==========================================
+ Hits        22020    22056      +36     
+ Misses       3828     3806      -22     
+ Partials     1205     1191      -14     

see 19 files with indirect coverage changes

@arjan-bal
Copy link
Contributor

It's not clear which issue this PR is trying to resolve. Please do the following:

  1. Mention in the PR description what this PR does.
  2. Resolve merge conflicts.
  3. Ensure all the tests pass.

After this you can re-open the PR.

@arjan-bal arjan-bal closed this Jul 30, 2024
@janardhanvissa janardhanvissa deleted the grpc-1894 branch September 16, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants