Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport/grpchttp2: add doc to methods and values #7445

Merged
merged 2 commits into from
Jul 31, 2024
Merged

transport/grpchttp2: add doc to methods and values #7445

merged 2 commits into from
Jul 31, 2024

Conversation

printchard
Copy link
Contributor

@printchard printchard commented Jul 26, 2024 •
edited
Loading

Add documentation to all exported methods and values.

RELEASE NOTES: none

@printchard printchard marked this pull request as ready for review July 26, 2024 20:34
@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (bc03420) to head (e90a1db).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7445      +/-   ##
==========================================
+ Coverage   81.39%   81.56%   +0.16%     
==========================================
  Files         354      354              
  Lines       27053    27076      +23     
==========================================
+ Hits        22020    22084      +64     
+ Misses       3828     3803      -25     
+ Partials     1205     1189      -16
Files Coverage Δ
internal/transport/grpchttp2/errors.go 100.00% <ø> (ø)
internal/transport/grpchttp2/framer.go 0.00% <ø> (ø)

... and 29 files with indirect coverage changes

@aranjans aranjans added this to the 1.66 Release milestone Jul 29, 2024
@aranjans aranjans added the Type: Internal Cleanup Refactors, etc label Jul 29, 2024
easwars
easwars reviewed Jul 29, 2024
View reviewed changes
internal/transport/grpchttp2/framer.go Outdated Show resolved Hide resolved
internal/transport/grpchttp2/framer.go Outdated Show resolved Hide resolved
@printchard printchard requested a review from easwars July 29, 2024 18:30
@printchard printchard assigned easwars and unassigned printchard Jul 29, 2024
@easwars easwars assigned arvindbr8 and unassigned easwars Jul 29, 2024
@easwars
Copy link
Contributor

easwars commented Jul 29, 2024

Moving to @arvindbr8 for second set of eyes.

arvindbr8
arvindbr8 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a question about how the linter works

internal/transport/grpchttp2/errors.go Show resolved Hide resolved
internal/transport/grpchttp2/framer.go Show resolved Hide resolved
@arvindbr8 arvindbr8 assigned printchard and unassigned arvindbr8 Jul 30, 2024
@dfawley dfawley assigned arvindbr8 and unassigned printchard Jul 30, 2024
@arvindbr8 arvindbr8 merged commit 6fa393c into grpc:master Jul 31, 2024
13 checks passed
@tbg tbg mentioned this pull request Nov 27, 2024
Draft
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

@easwars easwars easwars approved these changes

Assignees

@arvindbr8 arvindbr8

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.66 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@printchard @easwars @arvindbr8 @aranjans