Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transport/grpchttp2: add http2.Framer bridge #7453
transport/grpchttp2: add http2.Framer bridge #7453
Changes from 1 commit
f43d3b9
3b2ddb7
239a4dd
e00de1e
c91fc3b
e1dfe25
6490228
c9fa84d
6e784be
d71d065
6883fff
7b02e5f
37731a5
529afa6
b64f976
d412a87
3447612
c716f26
b04dd6d
c9454c4
0d5edcb
eafb63c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 77 in internal/transport/grpchttp2/errors.go
internal/transport/grpchttp2/errors.go#L76-L77
Check warning on line 57 in internal/transport/grpchttp2/framer.go
internal/transport/grpchttp2/framer.go#L56-L57
Check warning on line 249 in internal/transport/grpchttp2/framer.go
internal/transport/grpchttp2/framer.go#L249
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But once I typed the above comment, I had a thought as to whether it makes sense to accept the pool as a parameter instead of defaulting to the default pool.
Totally totally optional is the following: go/go-style/best-practices#option-structure. Even with the pool as a parameter, you will only have 4 arguments. So, not a big deal at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind 4 input parameters, I am happy leaving it as is. I will add the pool as a parameter as well.
Check warning on line 56 in internal/transport/grpchttp2/http2bridge.go
internal/transport/grpchttp2/http2bridge.go#L56
Check warning on line 77 in internal/transport/grpchttp2/http2bridge.go
internal/transport/grpchttp2/http2bridge.go#L76-L77
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to handle this type if the underlying framer is setup for meta frames, which is the default I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're totally right, we don't need to handle them for the adapter. Thanks.
Check warning on line 89 in internal/transport/grpchttp2/http2bridge.go
internal/transport/grpchttp2/http2bridge.go#L88-L89
Check warning on line 120 in internal/transport/grpchttp2/http2bridge.go
internal/transport/grpchttp2/http2bridge.go#L119-L120
Check warning on line 134 in internal/transport/grpchttp2/http2bridge.go
internal/transport/grpchttp2/http2bridge.go#L133-L134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ... I don't see any handling of this frame type in our current code. Do you happen to know how they are handled currently? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right again, we don't need to handle Continuation frames as they get automatically merged into Meta Headers frame.
Check warning on line 156 in internal/transport/grpchttp2/http2bridge.go
internal/transport/grpchttp2/http2bridge.go#L156
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done