Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/tools: update staticcheck version to latest #7509

Merged
merged 3 commits into from
Aug 14, 2024
Merged

test/tools: update staticcheck version to latest #7509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89df1fa
test/tools: update staticcheck version to latest
easwars Aug 14, 2024
c6232d0
make vet happy
easwars Aug 14, 2024
ed1e638
try again to make vet happy
easwars Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/features/customloadbalancer/client/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*
*/

package main

Check failure on line 19 in examples/features/customloadbalancer/client/main.go

View workflow job for this annotation

GitHub Actions / tests (vet, 1.22) 

should have a package comment https://revive.run/r#package-comments

import (
"context"
Expand Down Expand Up @@ -67,7 +67,7 @@
defer cancel()
ec := pb.NewEchoClient(cc)
if err := waitForDistribution(ctx, ec); err != nil {
log.Fatalf(err.Error())
log.Fatal(err)
}
fmt.Println("Successful multiple iterations of 1:2 ratio")
}
Expand Down
2 changes: 1 addition & 1 deletion internal/transport/transport_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1727,7 +1727,7 @@ func waitWhileTrue(t *testing.T, condition func() (bool, error)) {
if wait {
select {
case <-timer.C:
t.Fatalf(err.Error())
t.Fatal(err)
default:
time.Sleep(50 * time.Millisecond)
continue
Expand Down
10 changes: 5 additions & 5 deletions test/bufconn/bufconn_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func testRW(r io.Reader, w io.Writer) error {
func (s) TestPipe(t *testing.T) {
p := newPipe(10)
if err := testRW(p, p); err != nil {
t.Fatalf(err.Error())
t.Fatal(err)
}
}

Expand All @@ -97,10 +97,10 @@ func (s) TestConn(t *testing.T) {
c1, c2 := &conn{p1, p2}, &conn{p2, p1}

if err := testRW(c1, c2); err != nil {
t.Fatalf(err.Error())
t.Fatal(err)
}
if err := testRW(c2, c1); err != nil {
t.Fatalf(err.Error())
t.Fatal(err)
}
}

Expand Down Expand Up @@ -169,10 +169,10 @@ func (s) TestListener(t *testing.T) {
t.Fatalf("cerr = %v, serr = %v; want nil, nil", cerr, serr)
}
if err := testRW(c, s); err != nil {
t.Fatalf(err.Error())
t.Fatal(err)
}
if err := testRW(s, c); err != nil {
t.Fatalf(err.Error())
t.Fatal(err)
}
}

Expand Down
6 changes: 3 additions & 3 deletions test/tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
module google.golang.org/grpc/test/tools

go 1.21
go 1.22.1
printchard marked this conversation as resolved.
Show resolved Hide resolved

require (
github.com/client9/misspell v0.3.4
github.com/mgechev/revive v1.3.9
golang.org/x/tools v0.23.0
google.golang.org/protobuf v1.34.1
honnef.co/go/tools v0.4.7
honnef.co/go/tools v0.5.0
)

require (
github.com/BurntSushi/toml v1.4.0 // indirect
github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c // indirect
github.com/chavacava/garif v0.1.0 // indirect
github.com/fatih/color v1.17.0 // indirect
github.com/fatih/structtag v1.2.0 // indirect
Expand Down
8 changes: 4 additions & 4 deletions test/tools/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
github.com/BurntSushi/toml v1.4.0 h1:kuoIxZQy2WRRk1pttg9asf+WVv6tWQuBNVmK8+nqPr0=
github.com/BurntSushi/toml v1.4.0/go.mod h1:ukJfTF/6rtPPRCnwkur4qwRxa8vTRFBF0uk2lLoLwho=
github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c h1:pxW6RcqyfI9/kWtOwnv/G+AzdKuy2ZrqINhenH4HyNs=
github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c/go.mod h1:ukJfTF/6rtPPRCnwkur4qwRxa8vTRFBF0uk2lLoLwho=
github.com/chavacava/garif v0.1.0 h1:2JHa3hbYf5D9dsgseMKAmc/MZ109otzgNFk5s87H9Pc=
github.com/chavacava/garif v0.1.0/go.mod h1:XMyYCkEL58DF0oyW4qDjjnPWONs2HBqYKI+UIPD+Gww=
github.com/client9/misspell v0.3.4 h1:ta993UF76GwbvJcIo3Y68y/M3WxlpEHPWIGDkJYwzJI=
Expand Down Expand Up @@ -64,5 +64,5 @@ gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
honnef.co/go/tools v0.4.7 h1:9MDAWxMoSnB6QoSqiVr7P5mtkT9pOc1kSxchzPCnqJs=
honnef.co/go/tools v0.4.7/go.mod h1:+rnGS1THNh8zMwnd2oVOTL9QF6vmfyG6ZXBULae2uc0=
honnef.co/go/tools v0.5.0 h1:29uoiIormS3Z6R+t56STz/oI4v+mB51TSmEOdJPgRnE=
honnef.co/go/tools v0.5.0/go.mod h1:e9irvo83WDG9/irijV44wr3tbhcFeRnfpVlRqVwpzMs=
Loading