Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding: delete v1 proto codec and use one map for registry #7557

Merged
merged 3 commits into from
Aug 23, 2024

minimize diffs

0ede3f6
Select commit
Loading
Failed to load commit list.
Merged

encoding: delete v1 proto codec and use one map for registry #7557

minimize diffs
0ede3f6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 23, 2024 in 0s

81.71% (-0.09%) compared to 3d95421

View this Pull Request on Codecov

81.71% (-0.09%) compared to 3d95421

Details

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.71%. Comparing base (3d95421) to head (0ede3f6).

Files Patch % Lines
encoding/proto/proto.go 72.72% 4 Missing and 2 partials ⚠️
codec.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7557      +/-   ##
==========================================
- Coverage   81.79%   81.71%   -0.09%     
==========================================
  Files         362      361       -1     
  Lines       27832    27816      -16     
==========================================
- Hits        22765    22729      -36     
- Misses       3856     3875      +19     
- Partials     1211     1212       +1     
Files Coverage Δ
encoding/encoding.go 56.25% <100.00%> (-17.09%) ⬇️
encoding/encoding_v2.go 60.00% <100.00%> (+4.44%) ⬆️
codec.go 10.52% <50.00%> (-72.09%) ⬇️
encoding/proto/proto.go 66.66% <72.72%> (ø)

... and 19 files with indirect coverage changes