Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #7544 to v1.66.x branch #7565

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

arjan-bal
Copy link
Contributor

Original PR: #7544

RELEASE NOTES: None

…rpc#7544)

* Populate isssued count in LRS load report

* Test success, error and issued counts

* Make pass/faiil fractions unequal
@arjan-bal arjan-bal added the Type: Feature New features or improvements in behavior label Aug 26, 2024
@arjan-bal arjan-bal added this to the 1.66 Release milestone Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (8e3596c) to head (4e5ccbd).
Report is 1 commits behind head on v1.66.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.66.x    #7565      +/-   ##
===========================================
+ Coverage    81.76%   81.89%   +0.12%     
===========================================
  Files          361      361              
  Lines        27849    27858       +9     
===========================================
+ Hits         22771    22813      +42     
+ Misses        3870     3852      -18     
+ Partials      1208     1193      -15     
Files Coverage Δ
xds/internal/xdsclient/load/store.go 90.58% <100.00%> (+0.46%) ⬆️
xds/internal/xdsclient/transport/loadreport.go 82.57% <100.00%> (+0.13%) ⬆️

... and 16 files with indirect coverage changes

@arjan-bal arjan-bal requested a review from dfawley August 26, 2024 20:54
@arjan-bal arjan-bal merged commit 973e3dc into grpc:v1.66.x Aug 26, 2024
14 checks passed
@arjan-bal arjan-bal deleted the cherrypick/7544 branch August 26, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants