Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mem: replace flate.Reader reference #7595

Merged
merged 1 commit into from
Sep 11, 2024

mem: replace flate.Reader reference

614fd7f
Select commit
Loading
Failed to load commit list.
Merged

mem: replace flate.Reader reference #7595

mem: replace flate.Reader reference
614fd7f
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Sep 8, 2024 in 0s

3/3 Fail(s): LABEL, DESCRIPTION, MILESTONE

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    0 PASSED
    3 FAILED

Details

❌ Validator: LABEL

  • label does not include "^Type:"
    Input :
    Settings : {"must_include":{"regex":"^Type:"}}

❌ Validator: DESCRIPTION

  • description does not include "^RELEASE NOTES:\s([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\n(*|-)\s.+)$"**
    Input : This interface has nothing to do with compression and there are no other references to that package in the codebase. If we remove the reference we same compiler and linker some work - no need to parse, compile, link that package just to use one interface from it (assuming no other references from the codebase).
    Settings : {"must_include":{"regex":"^RELEASE NOTES:\\s*([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\\n(\\*|-)\\s*.+)$","regex_flag":"m"}}

❌ Validator: MILESTONE

  • milestone does not include "Release$"
    Input :
    Settings : {"must_include":{"regex":"Release$"}}