Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: fix docstring style #7643

Closed
wants to merge 1 commit into from

Conversation

purnesh42H
Copy link
Contributor

RELEASE NOTES: None

@purnesh42H purnesh42H added the Type: Documentation Documentation or examples label Sep 18, 2024
@purnesh42H purnesh42H added this to the 1.68 Release milestone Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.85%. Comparing base (11c44fb) to head (0f476dd).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7643      +/-   ##
==========================================
- Coverage   81.93%   81.85%   -0.08%     
==========================================
  Files         361      361              
  Lines       27816    27816              
==========================================
- Hits        22790    22769      -21     
- Misses       3837     3849      +12     
- Partials     1189     1198       +9     
Files with missing lines Coverage Δ
internal/channelz/server.go 90.69% <ø> (ø)
internal/channelz/trace.go 92.15% <ø> (ø)
internal/testutils/stats/test_metrics_recorder.go 72.35% <ø> (ø)

... and 19 files with indirect coverage changes

@arvindbr8
Copy link
Member

mmm, are these changes as part of #7444 ? Could you add more context to the description?

@dfawley dfawley changed the title .*: fix docstring style cleanup: fix docstring style Sep 20, 2024
@purnesh42H
Copy link
Contributor Author

purnesh42H commented Sep 23, 2024

mmm, are these changes as part of #7444 ? Could you add more context to the description?

no, just addressing some missed comments from #7575

@purnesh42H
Copy link
Contributor Author

Another PR with a bigger change is taking care of these https://github.com/grpc/grpc-go/pull/7614/files#diff-f56c03af87bcc3c1a80cce06e2d7b3920126f4e971b1fd94d2928621d48189fc

Closing this to avoid merge conflicts

@purnesh42H purnesh42H closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants