Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vet: add check to ensure terminating newline #7645

Merged
merged 86 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
4a56c02
change vet
eshitachandwani Sep 18, 2024
e762422
changing vet
eshitachandwani Sep 18, 2024
93cf5b7
Added error message
eshitachandwani Sep 18, 2024
8ab81a7
Added error message-1
eshitachandwani Sep 18, 2024
ff5ca0f
no newline needed
eshitachandwani Sep 18, 2024
373d857
remove ecoho
eshitachandwani Sep 18, 2024
18dd6f5
add echo
eshitachandwani Sep 18, 2024
dffa47c
add newline
eshitachandwani Sep 18, 2024
98435c2
newline check only for text and ms files
eshitachandwani Sep 18, 2024
eb54263
remove newline for other files
eshitachandwani Sep 18, 2024
c28adad
change command
eshitachandwani Sep 19, 2024
91a42c2
adding newline
eshitachandwani Sep 19, 2024
5a48fc5
avoiding errors
eshitachandwani Sep 19, 2024
47efadb
removing or true
eshitachandwani Sep 19, 2024
0cfcf88
adding or true
eshitachandwani Sep 19, 2024
da2b1a3
removing not
eshitachandwani Sep 19, 2024
5648b6d
not git grep
eshitachandwani Sep 19, 2024
2a009ee
remove sh errors
eshitachandwani Sep 19, 2024
caa6e2a
remove sh errors
eshitachandwani Sep 19, 2024
22eb0ab
remove sh errors
eshitachandwani Sep 19, 2024
b064b6e
remove sh errors
eshitachandwani Sep 19, 2024
510c50f
remove sh errors
eshitachandwani Sep 19, 2024
f3cc1e6
remove sh errors
eshitachandwani Sep 19, 2024
ebf019e
remove sh errors
eshitachandwani Sep 19, 2024
85df798
remove sh errors
eshitachandwani Sep 19, 2024
2884130
remove sh errors
eshitachandwani Sep 19, 2024
ba4758b
remove sh errors
eshitachandwani Sep 19, 2024
43120e3
remove sh errors
eshitachandwani Sep 19, 2024
c1ce1fd
remove sh errors
eshitachandwani Sep 19, 2024
eab85d0
remove sh errors
eshitachandwani Sep 19, 2024
869dc83
remove sh errors
eshitachandwani Sep 19, 2024
1a10485
remove sh errors
eshitachandwani Sep 19, 2024
682858a
remove sh errors
eshitachandwani Sep 19, 2024
414b281
remove sh errors
eshitachandwani Sep 19, 2024
0afced9
remove sh errors
eshitachandwani Sep 19, 2024
8e7b010
remove sh errors
eshitachandwani Sep 19, 2024
7f2dea3
remove sh errors
eshitachandwani Sep 19, 2024
8e01dcc
remove sh errors
eshitachandwani Sep 19, 2024
5ca8ff7
remove sh errors
eshitachandwani Sep 19, 2024
1f751ad
remove not
eshitachandwani Sep 20, 2024
d416784
remove not
eshitachandwani Sep 20, 2024
14c6c79
remove not
eshitachandwani Sep 20, 2024
786a60f
remove not
eshitachandwani Sep 20, 2024
39ecc40
remove not
eshitachandwani Sep 20, 2024
eec89f5
remove not
eshitachandwani Sep 20, 2024
30c58a5
remove not
eshitachandwani Sep 20, 2024
041ba75
remove not
eshitachandwani Sep 20, 2024
891f0de
remove not
eshitachandwani Sep 20, 2024
873c1ee
remove not
eshitachandwani Sep 20, 2024
b56152a
remove not
eshitachandwani Sep 20, 2024
83eb98e
remove not
eshitachandwani Sep 20, 2024
6308b5b
remove not
eshitachandwani Sep 20, 2024
9ee5e2d
remove not
eshitachandwani Sep 20, 2024
ffa319b
checking script
eshitachandwani Sep 20, 2024
8b7d9c4
checking script
eshitachandwani Sep 20, 2024
6406888
checking script
eshitachandwani Sep 20, 2024
6bc8207
checking script
eshitachandwani Sep 20, 2024
8433f72
checking script
eshitachandwani Sep 20, 2024
f6f6eb9
checking script
eshitachandwani Sep 20, 2024
0bdeeff
checking script
eshitachandwani Sep 20, 2024
d9651df
checking script
eshitachandwani Sep 20, 2024
f0a31e8
checking script
eshitachandwani Sep 20, 2024
d02f68a
checking script
eshitachandwani Sep 20, 2024
aa643fa
checking script
eshitachandwani Sep 20, 2024
6ae4fca
checking script
eshitachandwani Sep 20, 2024
56bad26
checking script
eshitachandwani Sep 20, 2024
daba557
checking script
eshitachandwani Sep 20, 2024
cbbfeef
checking script
eshitachandwani Sep 20, 2024
76551c0
checking script
eshitachandwani Sep 20, 2024
f880722
checking script
eshitachandwani Sep 20, 2024
e4df3a6
checking script
eshitachandwani Sep 20, 2024
0ce5c08
checking script
eshitachandwani Sep 20, 2024
d31ce47
checking script
eshitachandwani Sep 20, 2024
003107c
checking script
eshitachandwani Sep 20, 2024
7686eb9
checking script
eshitachandwani Sep 20, 2024
e5e74ac
checking script
eshitachandwani Sep 20, 2024
d42d05f
checking script
eshitachandwani Sep 20, 2024
b7cfdc4
checking script
eshitachandwani Sep 20, 2024
0a833a9
checking script
eshitachandwani Sep 20, 2024
d5e44b5
checking script
eshitachandwani Sep 20, 2024
9b322db
checking script
eshitachandwani Sep 20, 2024
c5e35a8
changing command
eshitachandwani Oct 1, 2024
51e6f01
adding newline
eshitachandwani Oct 1, 2024
35dd30e
Update vet.sh
eshitachandwani Oct 7, 2024
69322ad
Merge branch 'master' into eshita_5
eshitachandwani Oct 7, 2024
a1c7b90
Update vet.sh
eshitachandwani Oct 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Documentation/grpc-metadata.md
Original file line number Diff line number Diff line change
Expand Up @@ -241,4 +241,4 @@ available [here](../examples/features/metadata_interceptor/server/main.go).
[Header]: https://godoc.org/google.golang.org/grpc#Header
[Trailer]: https://godoc.org/google.golang.org/grpc#Trailer
[CallOption]: https://godoc.org/google.golang.org/grpc#CallOption
[metadata]: https://godoc.org/google.golang.org/grpc/metadata
[metadata]: https://godoc.org/google.golang.org/grpc/metadata
2 changes: 1 addition & 1 deletion examples/data/rbac/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@
}
],
"deny_rules": []
}
}
2 changes: 1 addition & 1 deletion examples/features/name_resolving/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ proper name resolver, this would fail. In the example it picks the `example`
resolver that we installed. The `example` resolver can handle
`resolver.example.grpc.io` correctly by returning the backend address. So even
though the backend IP is not set when ClientConn is created, the connection will
be created to the correct backend.
be created to the correct backend.
2 changes: 1 addition & 1 deletion reflection/test/grpc_testing_not_regenerate/dynamic.proto
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ message DynamicReq {}
service DynamicService {
// DynamicMessage1 is a test RPC for dynamically constructed protobufs.
rpc DynamicMessage1(DynamicReq) returns (DynamicRes);
}
}
3 changes: 3 additions & 0 deletions scripts/vet.sh
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ not git grep "\(import \|^\s*\)\"google.golang.org/grpc/interop/grpc_testing" --
# - Ensure that no trailing spaces are found.
not git grep '[[:blank:]]$'

# - Ensure that all files have a terminating newline.
git ls-files | not xargs -I {} sh -c '[ -n "$(tail -c 1 "{}" 2>/dev/null)" ] && echo "{}: No terminating new line found"' | fail_on_output

# - Ensure that no tabs are found in markdown files.
not git grep $'\t' -- '*.md'

Expand Down
2 changes: 1 addition & 1 deletion testdata/x509/client_with_spiffe_openssl.cnf
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ extendedKeyUsage = critical,clientAuth
subjectAltName = @alt_names

[alt_names]
URI = spiffe://foo.bar.com/client/workload/1
URI = spiffe://foo.bar.com/client/workload/1