-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-go-grpc: remove use_generic_streams_experimental
flag (defaults to true)
#7654
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7654 +/- ##
==========================================
- Coverage 81.80% 81.76% -0.04%
==========================================
Files 361 361
Lines 27821 27821
==========================================
- Hits 22758 22747 -11
- Misses 3862 3867 +5
- Partials 1201 1207 +6 |
@eshitachandwani please try regenerating the protos and run the relevant examples to make sure everything is correct |
CI should already be doing that |
cmd/protoc-gen-go-grpc/grpc.go
Outdated
} else { | ||
s += method.Parent.GoName + "_" + method.GoName + "Client" | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is 332 and 334 an empty line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM, modulo two comments.
Also instead of saying partially fixes #issue, we should say which part of the issue is fixed. From the looks of it, it seems like the only thing pending is a release?
use_generic_streams_experimental
flag (defaults to true)
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
that's great. good to know that |
I think we need the release notes? @arvindbr8 to confirm |
relnotes here are used by the release bot for gRPC releases only. relnotes for the plugin releases are handled manually. |
…efaults to true) (grpc#7654)
Fixes task 2 : #1894 - Delete the code to generate stream interfaces for client and server.
Deletes the unused code to make stream generics default.
RELEASE NOTES: None