clusterresolver/e2e_test: Avoid making real DNS requests in TestAggregateCluster_BadEDS_BadDNS #7669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
added
Type: Testing
Area: Testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7669 +/- ##
==========================================
- Coverage 81.80% 81.78% -0.02%
==========================================
Files 361 361
Lines 27821 27821
==========================================
- Hits 22758 22753 -5
- Misses 3862 3863 +1
- Partials 1201 1205 +4 |
easwars
approved these changes
Sep 25, 2024
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Oct 1, 2024
…gateCluster_BadEDS_BadDNS (grpc#7669)
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7354
The test is presently making a real DNS request for a non existing domain
bad.ip.v4.address. This makes the test non-hermitic and could be the cause of the test flaking. This change makes the test use a fake resolver to avoid making real DNS requests.A similar fix was made for TestAggregateCluster_BadDNS_GoodEDS in #7561 after which there were no more failures reported.
RELEASE NOTES: None