Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdsclient: switch more transport tests to e2e style (2/N) #7693

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 2, 2024

This PR moves more tests in the transport package to live at the xdsclient package and makes them e2e style.

This PR also makes the stream backoff configurable at the xDS client level. This will be used later on as well, as part of the refactor.

#a71-xds-fallback
#xdsclient-refactor

Addresses #6902

RELEASE NOTES: none

@easwars easwars requested a review from zasweq October 2, 2024 17:42
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Oct 2, 2024
@easwars easwars requested a review from purnesh42H October 2, 2024 17:43
@easwars easwars added this to the 1.68 Release milestone Oct 2, 2024
@zasweq zasweq assigned easwars and unassigned zasweq Oct 4, 2024
@easwars easwars assigned zasweq and unassigned easwars Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.83%. Comparing base (9afb232) to head (182188e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7693      +/-   ##
==========================================
+ Coverage   81.79%   81.83%   +0.03%     
==========================================
  Files         361      361              
  Lines       27822    27827       +5     
==========================================
+ Hits        22756    22771      +15     
+ Misses       3863     3856       -7     
+ Partials     1203     1200       -3     
Files with missing lines Coverage Δ
xds/internal/xdsclient/authority.go 89.24% <100.00%> (+0.03%) ⬆️
xds/internal/xdsclient/client_new.go 86.36% <100.00%> (+0.99%) ⬆️
xds/internal/xdsclient/client_refcounted.go 86.11% <100.00%> (ø)
xds/internal/xdsclient/clientimpl.go 90.00% <ø> (ø)
xds/internal/xdsclient/clientimpl_authority.go 84.90% <100.00%> (-3.56%) ⬇️

... and 23 files with indirect coverage changes

Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zasweq zasweq assigned easwars and unassigned zasweq Oct 7, 2024
@easwars easwars assigned zasweq and unassigned easwars and purnesh42H Oct 7, 2024
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zasweq zasweq assigned easwars and unassigned zasweq Oct 7, 2024
@easwars easwars force-pushed the transport_more_tests branch from f961246 to 2604316 Compare October 7, 2024 22:33
@easwars easwars merged commit 98d1550 into grpc:master Oct 7, 2024
14 checks passed
@easwars easwars deleted the transport_more_tests branch October 7, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants