xds: switching to stubserver in tests instead of testservice implementation #7726
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7726 +/- ##
==========================================
- Coverage 81.71% 81.66% -0.05%
==========================================
Files 374 374
Lines 38166 37978 -188
==========================================
- Hits 31188 31016 -172
+ Misses 5699 5643 -56
- Partials 1279 1319 +40 |
|
@easwars for second review |
xds/server_ext_test.go
Outdated
| server, err := xds.NewGRPCServer(grpc.Creds(insecure.NewCredentials()), modeChangeOpt, xds.BootstrapContentsForTesting(bootstrapContents)) | ||
| if err != nil { | ||
| t.Fatalf("Failed to create an xDS enabled gRPC server: %v", err) | ||
| } | ||
| defer server.Stop() | ||
| testgrpc.RegisterTestServiceServer(server, &testService{}) | ||
|
|
||
| stub.S = server | ||
| stubserver.StartTestService(t, stub) |
There was a problem hiding this comment.
combined server initialization and passed sopts to StartTestService.
|
@janardhankrishna-sai -- Also please mention the PR description why does this diff "partially" fix the issue. The last few comments in #7291 is also not very clear. |
janardhanvissa
force-pushed
the
stubserver-xds
branch
from
5bec96e to
05e54a4
Compare
janardhanvissa
force-pushed
the
stubserver-xds
branch
from
05e54a4 to
1b4f2f4
Compare
|
| t.Cleanup(func() { | ||
| stub.S.Stop() | ||
| }) |
There was a problem hiding this comment.
This should also work
| t.Cleanup(func() { | |
| stub.S.Stop() | |
| }) | |
| t.Cleanup(stub.S.Stop) |
There was a problem hiding this comment.
done with the change.
| fs, nodeID, port, cleanup := clientSetup(t) | ||
| defer cleanup() | ||
| fs, nodeID, port := clientSetup(t) | ||
|
|
There was a problem hiding this comment.
removed empty line
Partially Addresses: #7291
RELEASE NOTES: None