orca: switching to stubserver in tests instead of testservice implementation #7727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7727 +/- ##
==========================================
- Coverage 81.82% 81.81% -0.02%
==========================================
Files 361 374 +13
Lines 27828 37978 +10150
==========================================
+ Hits 22771 31071 +8300
- Misses 3857 5609 +1752
- Partials 1200 1298 +98 |
purnesh42H
reviewed
Oct 14, 2024
purnesh42H
reviewed
Oct 18, 2024
purnesh42H
reviewed
Oct 22, 2024
purnesh42H
reviewed
Oct 24, 2024
|
@easwars for second review |
arvindbr8
requested changes
Oct 29, 2024
janardhanvissa
force-pushed
the
stubserver-orca
branch
from
13e9a1d to
d092e1b
Compare
janardhanvissa
force-pushed
the
stubserver-orca
branch
from
d092e1b to
8026a64
Compare
|
@arvindbr8 for re-review |
arvindbr8
requested changes
Nov 11, 2024
…n part and moved the usage of numRequests
arvindbr8
approved these changes
Nov 13, 2024
orca/service_test.go
Outdated
| stub := &stubserver.StubServer{ | ||
| Listener: lis, | ||
| UnaryCallF: func(ctx context.Context, req *testpb.SimpleRequest) (*testpb.SimpleResponse, error) { | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Addresses: #7291
RELEASE NOTES: None