Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: refactor trInFlow.onData to eliminate redundant logic #7734

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

luxcgo
Copy link
Contributor

@luxcgo luxcgo commented Oct 11, 2024

RELEASE NOTES: None

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (b850ea5) to head (b2a3a62).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7734      +/-   ##
==========================================
+ Coverage   81.96%   82.17%   +0.21%     
==========================================
  Files         362      362              
  Lines       28119    28116       -3     
==========================================
+ Hits        23048    23105      +57     
+ Misses       3863     3826      -37     
+ Partials     1208     1185      -23     
Files with missing lines Coverage Δ
internal/transport/flowcontrol.go 96.77% <100.00%> (-0.11%) ⬇️

... and 22 files with indirect coverage changes

@arjan-bal arjan-bal self-requested a review October 15, 2024 07:32
@arjan-bal arjan-bal self-assigned this Oct 15, 2024
@arjan-bal arjan-bal added the Type: Internal Cleanup Refactors, etc label Oct 15, 2024
@arjan-bal arjan-bal added this to the 1.68 Release milestone Oct 15, 2024
@arjan-bal arjan-bal changed the title trInFlow: refactor onData to eliminate redundant logic transport: refactor trInFlow.onData to eliminate redundant logic Oct 15, 2024
Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding a second reviewer.

@arjan-bal arjan-bal requested a review from easwars October 15, 2024 08:19
@arjan-bal arjan-bal assigned easwars and unassigned arjan-bal Oct 15, 2024
@purnesh42H purnesh42H modified the milestones: 1.68 Release, 1.69 Release Oct 16, 2024
@easwars easwars merged commit ec10e73 into grpc:master Oct 16, 2024
15 checks passed
@purnesh42H purnesh42H added the Area: Transport Includes HTTP/2 client/server and HTTP server handler transports and advanced transport features. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Transport Includes HTTP/2 client/server and HTTP server handler transports and advanced transport features. Type: Internal Cleanup Refactors, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants