github: add Go 1.23 testing and make staticcheck work locally with go1.23 #7751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7751 +/- ##
==========================================
- Coverage 82.22% 79.61% -2.61%
==========================================
Files 362 365 +3
Lines 28116 36362 +8246
==========================================
+ Hits 23118 28951 +5833
- Misses 3819 6203 +2384
- Partials 1179 1208 +29 |
dfawley
reviewed
Oct 18, 2024
.github/workflows/testing.yml
Outdated
| @@ -43,35 +43,35 @@ jobs: | |||
| matrix: | |||
| include: | |||
| - type: vet | |||
| goversion: '1.22' | |||
| goversion: '1.23' | |||
There was a problem hiding this comment.
I thought we agreed to keep vet running at 1.22?
There was a problem hiding this comment.
You're right, reverted to 1.22 for vet. There is a problem in vet.sh where it sets PATH using GOROOT even when GOROOT is unset. Because of that, vet was using go1.23. I've made the fix in this PR.
arjan-bal
force-pushed
the
bump-ci-go-version
branch
2 times, most recently
from
29fab3b to
ac7e7be
Compare
arjan-bal
force-pushed
the
bump-ci-go-version
branch
from
ac7e7be to
6526e71
Compare
arjan-bal
force-pushed
the
bump-ci-go-version
branch
from
7ba5dff to
f56e2c4
Compare
arjan-bal
force-pushed
the
bump-ci-go-version
branch
from
f56e2c4 to
84a2ba6
Compare
arjan-bal
changed the title
arjan-bal
changed the title
|
@dfawley, I've removed the |
dfawley
approved these changes
Oct 25, 2024
arjan-bal
added
the
Area: Tooling
misvivek
pushed a commit
to misvivek/grpc-go
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: None