Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #7702 into v1.68.x #7791

Closed
wants to merge 39 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
4544b8a
Change version to 1.69.0-dev (#7746)
purnesh42H Oct 16, 2024
569c8eb
vet: Use go1.22 instead of go1.21 for tidy and staticcheck(#7747)
arjan-bal Oct 16, 2024
6cd00c9
clientconn: remove redundant check (#7700)
luxcgo Oct 16, 2024
ec10e73
transport: refactor `trInFlow.onData` to eliminate redundant logic (#…
luxcgo Oct 16, 2024
d2ded4b
xdsclient: new Transport interface and LRS stream implementation (#7717)
easwars Oct 17, 2024
830135e
xdsclient: new Transport interface and ADS stream implementation (#7721)
easwars Oct 17, 2024
56df169
resolver: update ReportError() docstring (#7732)
purnesh42H Oct 17, 2024
98959d9
deps: update dependencies for all modules (#7755)
purnesh42H Oct 18, 2024
14e2a20
resolver/google-c2p: introduce SetUniverseDomain API (#7719)
apolcyn Oct 21, 2024
c538c31
vet: Don't use GOROOT to set PATH if GOROOT is unset (#7761)
arjan-bal Oct 22, 2024
80937a9
credentials: Apply defaults to TLS configs provided through GetConfig…
arjan-bal Oct 22, 2024
4bb0170
status: Fix status incompatibility introduced by #6919 and move non-r…
arjan-bal Oct 22, 2024
8212cf0
xdsclient: implementation of the xdsChannel (#7757)
easwars Oct 23, 2024
c4c8b11
xds/resolver: add a way to specify the xDS client to use for testing …
easwars Oct 24, 2024
f8e5d8f
mem: use slice capacity instead of length, to determine whether to po…
PapaCharlie Oct 24, 2024
e0a730c
clusterresolver: fix a comment in a test (#7776)
easwars Oct 25, 2024
a82315c
testutils: change ListenerWrapper to push the most recently accepted …
easwars Oct 25, 2024
94e1b29
vet: add dependency checks (#7766)
dfawley Oct 25, 2024
67b9ebf
xdsclient: make sending requests more deterministic (#7774)
easwars Oct 25, 2024
a0cbb52
github: add Go 1.23 testing and make staticcheck work locally with go…
arjan-bal Oct 25, 2024
cb32937
credentials: Support ALTSPerRPCCreds in DefaultCredentialsOptions (#7…
rockspore Oct 25, 2024
ada6787
cleanup: switching to stubserver in tests instead of testservice impl…
janardhanvissa Oct 28, 2024
4084b14
stats/opentelemetry: Remove OpenTelemetry module and add RLS Metrics …
zasweq Oct 28, 2024
e7435d6
balancer/endpointsharding: Ignore empty endpoints (#7674)
zasweq Oct 28, 2024
192ee33
multiple: add verbosity checks to logs that use pretty.JSON (#7785)
easwars Oct 28, 2024
a197f9b
stats: opentelemetry GrpcTraceBinPropagator
purnesh42H Sep 1, 2024
3df92be
Address style, clarification review comments
purnesh42H Oct 6, 2024
d9f548b
Make *CustomCarrier implement carrier interface
purnesh42H Oct 9, 2024
857b023
Address 2nd round of style, docstring comments
purnesh42H Oct 9, 2024
afe897e
use cmp.equal with cmpopts.SortSlices for equating keys slices
purnesh42H Oct 13, 2024
1b8e64a
separate fast path and slow path tests
purnesh42H Oct 16, 2024
24a9f2b
Addressing documentation comments
purnesh42H Oct 18, 2024
ccb0b30
rewrite FromBinary as C core and add unit tests
purnesh42H Oct 20, 2024
80530d6
handle grpc-trace-bin keys for regular get and set
purnesh42H Oct 20, 2024
89f21ed
Address nits
purnesh42H Oct 22, 2024
4a81f71
don't allow any other binary header except grpc-trace-bin
purnesh42H Oct 24, 2024
eec4212
Suffix -bin instead of bin
purnesh42H Oct 25, 2024
2dfe0c3
address testing comments of merging in t-test and updating top level …
purnesh42H Oct 26, 2024
c039978
mem: use slice capacity instead of length, to determine whether to po…
PapaCharlie Oct 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
vet: add dependency checks (#7766)
dfawley authored Oct 25, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 94e1b29a1ca2e146087af7cd6c1e04a1aea56a58
43 changes: 43 additions & 0 deletions .github/workflows/deps.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Dependency Changes

# Trigger on PRs.
on:
pull_request:

permissions:
contents: read

jobs:
# Compare dependencies before and after this PR.
dependencies:
runs-on: ubuntu-latest
timeout-minutes: 10
strategy:
fail-fast: true

steps:
- name: Checkout repo
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: stable
cache-dependency-path: "**/*go.sum"

# Run the commands to generate dependencies before and after and compare.
- name: Compare dependencies
run: |
BEFORE="$(mktemp -d)"
AFTER="$(mktemp -d)"
scripts/gen-deps.sh "${AFTER}"
git checkout origin/master
scripts/gen-deps.sh "${BEFORE}"
echo "Comparing dependencies..."
# Run grep in a sub-shell since bash does not support ! in the middle of a pipe
diff -u0 -r "${BEFORE}" "${AFTER}" | bash -c '! grep -v "@@"'
echo "No changes detected."
21 changes: 21 additions & 0 deletions scripts/gen-deps.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#!/bin/bash

set -e # Exit on error
set -o pipefail # Fail a pipe if any sub-command fails.

if [[ "$#" -ne 1 || ! -d "$1" ]]; then
echo "Specify a valid output directory as the first parameter."
exit 1
fi

SCRIPTS_DIR="$(dirname "$0")"
OUTPUT_DIR="$1"

cd "${SCRIPTS_DIR}/.."

git ls-files -- '*.go' | grep -v '\(^\|/\)\(internal\|examples\|benchmark\|interop\|test\|testdata\)\(/\|$\)' | xargs dirname | sort -u | while read d; do
pushd "$d" > /dev/null
pkg="$(echo "$d" | sed 's;\.;grpc;' | sed 's;/;_;g')"
go list -deps . | sort >| "${OUTPUT_DIR}/$pkg"
popd > /dev/null
done