Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #7861 to 1.68.x #7873

Merged
merged 1 commit into from
Nov 26, 2024
Merged

cherry-pick #7861 to 1.68.x #7873

merged 1 commit into from
Nov 26, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 25, 2024

We will need a patch release for this. Can you take care of that please @purnesh42H?

RELEASE NOTES:

  • credentials/alts: disable SRV and TXT lookups for handshaker service to prevent timeouts when retrieving credentials on systems containing a known bug in systemd-resolved.

@dfawley dfawley added the Type: Behavior Change Behavior changes not categorized as bugs label Nov 25, 2024
@dfawley dfawley added this to the 1.68 Release milestone Nov 25, 2024
@dfawley dfawley requested a review from purnesh42H November 25, 2024 22:42
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.58%. Comparing base (eff4b16) to head (a7fe533).
Report is 1 commits behind head on v1.68.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.68.x    #7873      +/-   ##
===========================================
- Coverage    81.76%   81.58%   -0.19%     
===========================================
  Files          364      364              
  Lines        35910    35914       +4     
===========================================
- Hits         29363    29300      -63     
- Misses        5354     5411      +57     
- Partials      1193     1203      +10     
Files with missing lines Coverage Δ
...ntials/alts/internal/handshaker/service/service.go 69.23% <100.00%> (+2.56%) ⬆️
internal/resolver/dns/dns_resolver.go 89.47% <100.00%> (+0.07%) ⬆️

... and 19 files with indirect coverage changes

@purnesh42H purnesh42H merged commit dc26fee into grpc:v1.68.x Nov 26, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants