Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #7861 to 1.67.x #7878

Merged
merged 1 commit into from
Nov 27, 2024
Merged

cherry-pick #7861 to 1.67.x #7878

merged 1 commit into from
Nov 27, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 26, 2024

Sorry, it turns out GCS needs a patch release of 1.67 for this.

Original PR: #7861

RELEASE NOTES:

  • credentials/alts: disable SRV and TXT lookups for handshaker service to prevent timeouts when retrieving credentials on systems containing a known bug in systemd-resolved.

@dfawley dfawley added the Type: Behavior Change Behavior changes not categorized as bugs label Nov 26, 2024
@dfawley dfawley added this to the 1.67 Release milestone Nov 26, 2024
@dfawley dfawley requested a review from purnesh42H November 26, 2024 21:16
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (a1c3cfb) to head (a396f1e).
Report is 1 commits behind head on v1.67.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.67.x    #7878      +/-   ##
===========================================
- Coverage    81.77%   80.95%   -0.82%     
===========================================
  Files          361      361              
  Lines        27817    35285    +7468     
===========================================
+ Hits         22746    28564    +5818     
- Misses        3866     5525    +1659     
+ Partials      1205     1196       -9     
Files with missing lines Coverage Δ
...ntials/alts/internal/handshaker/service/service.go 69.23% <100.00%> (+0.80%) ⬆️
internal/resolver/dns/dns_resolver.go 89.47% <100.00%> (-1.40%) ⬇️

... and 313 files with indirect coverage changes

Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@purnesh42H purnesh42H merged commit 44c2aff into grpc:v1.67.x Nov 27, 2024
13 of 14 checks passed
@dfawley dfawley deleted the cp7861 branch December 3, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants