Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/internal: provide xDS node ID in control plane errors #7909

Closed
wants to merge 4 commits into from

Conversation

townba
Copy link
Contributor

@townba townba commented Dec 6, 2024

To fix internal b/364405720 ("Provide xDS node id in control plane errors (Golang)").

RELEASE NOTES: none

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.12%. Comparing base (66ba4b2) to head (a3c0554).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
xds/internal/balancer/cdsbalancer/cdsbalancer.go 55.55% 8 Missing ⚠️
xds/internal/resolver/xds_resolver.go 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7909      +/-   ##
==========================================
+ Coverage   82.04%   82.12%   +0.07%     
==========================================
  Files         377      377              
  Lines       38180    38192      +12     
==========================================
+ Hits        31326    31365      +39     
+ Misses       5551     5532      -19     
+ Partials     1303     1295       -8     
Files with missing lines Coverage Δ
xds/internal/resolver/xds_resolver.go 79.75% <72.72%> (+0.37%) ⬆️
xds/internal/balancer/cdsbalancer/cdsbalancer.go 82.01% <55.55%> (+0.26%) ⬆️

... and 17 files with indirect coverage changes

@dfawley
Copy link
Member

dfawley commented Dec 10, 2024

Closing until a strategy for logging (etc) node ID is decided.

@dfawley dfawley closed this Dec 10, 2024
@townba
Copy link
Contributor Author

townba commented Dec 13, 2024

#7931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants