test: switching to stubserver in tests instead of testservice #7925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7925 +/- ##
==========================================
+ Coverage 82.04% 82.20% +0.15%
==========================================
Files 377 379 +2
Lines 38180 38261 +81
==========================================
+ Hits 31326 31453 +127
+ Misses 5551 5517 -34
+ Partials 1303 1291 -12 |
pvsravani
force-pushed
the
stubserver-test2
branch
from
29ddfe9 to
05fb347
Compare
|
@easwars for second review |
easwars
reviewed
Dec 16, 2024
test/balancer_test.go
Outdated
Comment on lines
420
to
427
| stub := &stubserver.StubServer{ | ||
| Listener: lis, | ||
| EmptyCallF: func(_ context.Context, _ *testpb.Empty) (*testpb.Empty, error) { | ||
| return &testpb.Empty{}, nil | ||
| }, | ||
| } | ||
|
|
||
| stub.S = grpc.NewServer() |
There was a problem hiding this comment.
How about moving the initialization of the S field inside the literal struct defintion?
stub := &stubserver.StubServer{
Listener: lis,
EmptyCallF: func(_ context.Context, _ *testpb.Empty) (*testpb.Empty, error) {
return &testpb.Empty{}, nil
},
S: grpc.NewServer(),
}Here and in the other three places in this PR.
easwars
approved these changes
Dec 18, 2024
vinothkumarr227
pushed a commit
to vinothkumarr227/grpc-go
that referenced
this pull request
Dec 23, 2024
vinothkumarr227
added a commit
to vinothkumarr227/grpc-go
that referenced
this pull request
Dec 23, 2024
…grpc#7925)" This reverts commit 5541486.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Addresses: #7291
RELEASE NOTES: None