Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #7991 to v1.70.x #8004

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Jan 13, 2025

Original PR: #7991
Relates issue: #7982

RELEASE NOTES: N/A

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.98%. Comparing base (724f450) to head (6df0b67).
Report is 1 commits behind head on v1.70.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.70.x    #8004      +/-   ##
===========================================
- Coverage    82.28%   81.98%   -0.30%     
===========================================
  Files          381      381              
  Lines        38539    38542       +3     
===========================================
- Hits         31712    31600     -112     
- Misses        5535     5615      +80     
- Partials      1292     1327      +35     
Files with missing lines Coverage Δ
...internal/balancer/clusterresolver/configbuilder.go 91.07% <100.00%> (+0.16%) ⬆️

... and 22 files with indirect coverage changes

Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arjan-bal arjan-bal merged commit 62b9185 into grpc:v1.70.x Jan 13, 2025
14 of 15 checks passed
@arjan-bal arjan-bal deleted the cherrypick-7991 branch January 13, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants