Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove fake petiole in health tests #8082

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Feb 12, 2025

Fixes: #7906

The roundrobin balancer is using leaf pickfirst balancers since #7966. The fake petiole policy is no longer needed to test the health producer.

RELEASE NOTES: N/A

@arjan-bal arjan-bal added Type: Internal Cleanup Refactors, etc Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. labels Feb 12, 2025
@arjan-bal arjan-bal added this to the 1.71 Release milestone Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (ad5cd32) to head (618e40f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8082      +/-   ##
==========================================
+ Coverage   82.10%   82.30%   +0.20%     
==========================================
  Files         387      387              
  Lines       39067    39064       -3     
==========================================
+ Hits        32076    32153      +77     
+ Misses       5662     5599      -63     
+ Partials     1329     1312      -17     

see 28 files with indirect coverage changes

@easwars easwars assigned arjan-bal and unassigned easwars Feb 12, 2025
@easwars
Copy link
Contributor

easwars commented Feb 12, 2025

Woohooo!

@arjan-bal arjan-bal merged commit cf60e5a into grpc:master Feb 13, 2025
15 checks passed
@arjan-bal arjan-bal deleted the cleanup-health-test branch February 13, 2025 04:25
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Type: Internal Cleanup Refactors, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

health: Remove the fake petiole policy used for testing once round robin delegates to pickfirst
2 participants