-
Notifications
You must be signed in to change notification settings - Fork 4.6k
deps: bump go version to 1.24 #8509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8509 +/- ##
==========================================
- Coverage 82.40% 81.74% -0.66%
==========================================
Files 414 413 -1
Lines 40531 40525 -6
==========================================
- Hits 33399 33129 -270
- Misses 5770 6008 +238
- Partials 1362 1388 +26 🚀 New features to boost your workflow:
|
Hi @kevinGC, can you also bump the Go versions used for CI tests similar to this change? |
It's generally useful to have new-and-improved Go. One specific useful feature is `b.Loop()`, which makes benchmarking easier.
Thanks for the review. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, adding a second reviewer.
Just FYI, gRPC Go supports the two most recent major versions of Golang, which aligns with Go's support policy. I'm not sure if it's a coincidence that this PR came just 6 hours after Go 1.25 was released. :)
It's generally useful to have new-and-improved Go. One specific useful feature is
b.Loop()
, which makes benchmarking easier.Encountered while working on #8510, as I was using
b.Loop()
in my benchmarks.RELEASE NOTES: