Cherry pick #8483 into v1.75.x #8541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.75.x #8541 +/- ##
===========================================
- Coverage 81.77% 81.54% -0.24%
===========================================
Files 413 413
Lines 40530 40623 +93
===========================================
- Hits 33145 33126 -19
- Misses 6003 6029 +26
- Partials 1382 1468 +86
🚀 New features to boost your workflow:
|
Contributor
|
Why do we need to cherry-pick #8467? It's a fix for a flaky test, right? |
Member
Author
Contributor
|
We don't need to cherry-pick fixes for flaky tests. |
Fixes: grpc#8474 The race is in [ReportLoad](https://github.com/grpc/grpc-go/blob/9186ebd774370e3b3232d1b202914ff8fc2c56d6/xds/internal/xdsclient/clientimpl_loadreport.go#L35C2-L44C21) function of clientImpl. The implementation was recently changed as the part of [xds client migration](grpc@082a927). The [comment](https://github.com/grpc/grpc-go/blob/85240a5b02defe7b653ccba66866b4370c982b6a/xds/internal/xdsclient/clientimpl.go#L86C2-L87C16) says that `lrsclient.LRSClient` should be initialized only at creation time but that was not the case. It was being initialized at the time of calling `ReportLoad` function. RELEASE NOTES: - lrsclient: - Fix a race condition where the `LRSClient` was not initialized at creation time but it was being initialized at the time of calling the `ReportLoad` function. - Creating an `LRSClient` no longer requires a node ID.
eshitachandwani
force-pushed
the
v1.75.x
branch
from
a714734 to
120046e
Compare
eshitachandwani
changed the title
Contributor
+1 |
easwars
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #8483
Related issue: #8474
RELEASE NOTES:
LRSClientwas not initialized atcreation time but it was being initialized at the time of calling the
ReportLoadfunction.LRSClientno longer requires a node ID.