-
Notifications
You must be signed in to change notification settings - Fork 4.6k
xds/resolver: use dependency manager to get LDS and RDS #8687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eshitachandwani
wants to merge
17
commits into
grpc:master
Choose a base branch
from
eshitachandwani:new_xds_resolver
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8687 +/- ##
==========================================
+ Coverage 83.28% 83.36% +0.07%
==========================================
Files 415 418 +3
Lines 32134 32199 +65
==========================================
+ Hits 26763 26842 +79
+ Misses 4005 4000 -5
+ Partials 1366 1357 -9
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: xDS
Includes everything xDS related, including LB policies used with xDS.
Type: Internal Cleanup
Refactors, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of A74 implementation.
This PR removes the listener and route watchers from resolver and changes it so that we get the resources from xds dependency manager.
Note : This also includes the changes from #8651 since the changes in this PR are dependent on that. The changes in this PR will reduce after #8651 is merged. The changes of this PR are in the following files only :
RELEASE NOTES: N/A