Skip to content

Conversation

@mbissa
Copy link
Contributor

@mbissa mbissa commented Nov 11, 2025

Addresses :

This PR makes available backend service (cluster name) label which is decided in clusterimpl (since we are pre-A75). It is added to weighted round robin per call metrics.
Also, this PR adds sub channel metrics which will eventually replace the pick first metrics.

RELEASE NOTES:

  • stats/otel: add backend service label to wrr metrics and add subchannel metrics to eventually replace the pickfirst metrics

@mbissa mbissa requested a review from easwars November 11, 2025 20:42
@mbissa mbissa added Type: Feature New features or improvements in behavior Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability labels Nov 11, 2025
@mbissa mbissa added this to the 1.78 Release milestone Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 94.11765% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.19%. Comparing base (749af0c) to head (f3860ad).

Files with missing lines Patch % Lines
internal/testutils/stats/test_metrics_recorder.go 80.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8701      +/-   ##
==========================================
- Coverage   83.30%   83.19%   -0.12%     
==========================================
  Files         419      419              
  Lines       32450    32515      +65     
==========================================
+ Hits        27033    27050      +17     
- Misses       4039     4060      +21     
- Partials     1378     1405      +27     
Files with missing lines Coverage Δ
balancer/weightedroundrobin/balancer.go 85.87% <100.00%> (+0.32%) ⬆️
balancer/weightedroundrobin/scheduler.go 96.22% <100.00%> (ø)
clientconn.go 90.47% <100.00%> (-0.28%) ⬇️
internal/internal.go 100.00% <ø> (ø)
internal/transport/http2_client.go 92.23% <100.00%> (-0.68%) ⬇️
internal/transport/transport.go 88.70% <ø> (-2.16%) ⬇️
internal/xds/balancer/clusterimpl/clusterimpl.go 83.79% <100.00%> (+0.07%) ⬆️
internal/xds/xds.go 81.08% <100.00%> (+6.08%) ⬆️
resolver/resolver.go 100.00% <100.00%> (ø)
internal/testutils/stats/test_metrics_recorder.go 79.48% <80.00%> (+5.87%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbissa mbissa removed the request for review from easwars November 11, 2025 20:45
@mbissa mbissa force-pushed the a94-subchannel-metrics-with-labels branch 7 times, most recently from 627d2ca to fba7b07 Compare November 13, 2025 09:15
@dfawley dfawley changed the title stats/otel : add backend service attribute to weighted round robin metrics and add subchannel metrics stats/otel: add backend service attribute to weighted round robin metrics and add subchannel metrics Nov 18, 2025
@mbissa mbissa force-pushed the a94-subchannel-metrics-with-labels branch from fba7b07 to ff620f6 Compare December 1, 2025 00:39
@mbissa mbissa requested a review from easwars December 1, 2025 00:45
@easwars easwars assigned easwars and unassigned mbissa Dec 1, 2025
@easwars
Copy link
Contributor

easwars commented Dec 1, 2025

This PR seems to address two things which are not directly related to each other:

  • subchannel metrics
  • adding the backend service label to WRR metrics

Can this be split into two PRs instead?

@easwars easwars assigned mbissa and unassigned easwars Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability Type: Feature New features or improvements in behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants