clientconn: Wait for health check when closing the transport #8783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8783 +/- ##
==========================================
- Coverage 83.33% 83.29% -0.04%
==========================================
Files 418 418
Lines 32910 32921 +11
==========================================
- Hits 27424 27421 -3
- Misses 4088 4095 +7
- Partials 1398 1405 +7
🚀 New features to boost your workflow:
|
clientconn.go
Outdated
| func (ac *addrConn) createTransport(ctx context.Context, addr resolver.Address, copts transport.ConnectOptions, connectDeadline time.Time) error { | ||
| addr.ServerName = ac.cc.getServerName(addr) | ||
|
|
||
| var healthCheckDone <-chan struct{} |
Member
There was a problem hiding this comment.
I think healthCheckCh and healthCheckDoneCh might be slightly better variable names to indicate that these are channels.
|
|
||
| ac.mu.Lock() | ||
| defer ac.mu.Unlock() | ||
| defer func() { |
Member
There was a problem hiding this comment.
Can you add a small note stating where the healthCheckComplete is set and why do we wait on healthCheckComplete instead of healthCheckDone.
Contributor
Author
There was a problem hiding this comment.
Added some comments. Hope they're helpful.
The health check goroutine could outlive a call to ClientConn.close(). Add a done channel that will be waited on when closing the transport. RELEASE NOTES: - Closing a client connection will now block until the health check goroutine completes. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
force-pushed
the
clientconn-wait-for-healthcheck
branch
from
bfd0214 to
599fb48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The health check goroutine could outlive a call to
ClientConn.close(). Add a done channel that will be waited on when closing the transport.See:
RELEASE NOTES: